Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19927 )
Change subject: IMPALA-11123: Reimplement ORC optimized count star ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/19927/3/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/19927/3/be/src/exec/orc/hdfs-orc-scanner.cc@409 PS3, Line 409: if (scan_node_->optimize_count_star()) { it is possible for row_batches_need_validation_ to be true while scan_node_->optimize_count_star() is also true? I think that we cannot use the optimization in that case. http://gerrit.cloudera.org:8080/#/c/19927/3/be/src/exec/orc/hdfs-orc-scanner.cc@811 PS3, Line 811: else if (scan_node_->IsZeroSlotTableScan() && !row_batches_need_validation_) { this formatting is very unusual in Impala - can you move the else if to line 807 after } and move the comment inside the block? http://gerrit.cloudera.org:8080/#/c/19927/3/testdata/workloads/functional-query/queries/QueryTest/partition-key-scans.test File testdata/workloads/functional-query/queries/QueryTest/partition-key-scans.test: http://gerrit.cloudera.org:8080/#/c/19927/3/testdata/workloads/functional-query/queries/QueryTest/partition-key-scans.test@18 PS3, Line 18: aggregation(SUM, RowsRead): 0 Is there a reason behind returning number of files in Parquet and 0 in ORC? The ORC scanner could also increment the counter in the count(*) path with COUNTER_ADD(scan_node_->rows_read_counter(), 1); http://gerrit.cloudera.org:8080/#/c/19927/3/tests/util/test_file_parser.py File tests/util/test_file_parser.py: http://gerrit.cloudera.org:8080/#/c/19927/3/tests/util/test_file_parser.py@269 PS3, Line 269: if subsection_comment is not None and subsection_comment is not "": this block looks more complex than necessary can you create function like parse_runtime_profile_table_formats() that does the parsing / allowed format checking and returns the list of parsed_formats? -- To view, visit http://gerrit.cloudera.org:8080/19927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5971c8f278e1dee44e2a8dd4d2f043d22ebf5d17 Gerrit-Change-Number: 19927 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 22 Feb 2024 14:38:16 +0000 Gerrit-HasComments: Yes
