Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21047 )
Change subject: IMPALA-12828: Remove Usage of Unnecessary this-> ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21047/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21047/3//COMMIT_MSG@9 PS3, Line 9: 408c606 > nit. include the related Jira ticket IMPALA-12426 in the commit message mig The rules about how to handle JIRA tickets aren't always clear. But I'd argue this is an addendum to the original commit and should use the same ticket rather than a sub-ticket. -- To view, visit http://gerrit.cloudera.org:8080/21047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6b1d8ba7e27d20ba1ac83caff5e56fd0f9347c0 Gerrit-Change-Number: 21047 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 22 Feb 2024 17:54:17 +0000 Gerrit-HasComments: Yes
