Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21072 )
Change subject: WIP IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21072/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21072/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2133 PS1, Line 2133: // Try adding the partition ids and names if we can acquire the read lock. Would it be hard to synchronize access to partitionMap_? I could be done and in the few places where we add/remove partitions. In other places where we iterate through it the thread safety is already solved somehow I guess. Once the collection is synchronized, I think that there shouldn't be problems, as the partition ID is shouldn't change. http://gerrit.cloudera.org:8080/#/c/21072/1/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/21072/1/tests/custom_cluster/test_concurrent_ddls.py@215 PS1, Line 215: handle refresh_handle would be clearer ase there are other operations in parallel -- To view, visit http://gerrit.cloudera.org:8080/21072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9f8e65c0bd24000241eedf8ca765c1e4e14fdb3 Gerrit-Change-Number: 21072 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 17:30:30 +0000 Gerrit-HasComments: Yes
