Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21059 )
Change subject: IMPALA-12426: QueryStateRecord Refactor ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/21059/5/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/21059/5/be/src/runtime/coordinator.h@268 PS5, Line 268: /// Return the backends and their associate resource utilization. nit: associated http://gerrit.cloudera.org:8080/#/c/21059/5/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/21059/5/be/src/service/client-request-state.h@285 PS5, Line 285: /// num_rows_fetched_counter_, row_materialization_rate_, and row_materialization_rate_ row_materialization_rate_ repeated, I think you meant the last one to be row_materialization_timer_. http://gerrit.cloudera.org:8080/#/c/21059/5/be/src/service/query-state-record.h File be/src/service/query-state-record.h: http://gerrit.cloudera.org:8080/#/c/21059/5/be/src/service/query-state-record.h@219 PS5, Line 219: EventsTimelineIterator begin(); It's a little funny that this is both a container view and an iterator. But I don't see a specific problem with that. http://gerrit.cloudera.org:8080/#/c/21059/5/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/21059/5/common/thrift/Query.thrift@995 PS5, Line 995: 15: optional i64 planner_per_host_mem_estimate; Can we pull in the Planner.java change that initializes this field? -- To view, visit http://gerrit.cloudera.org:8080/21059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d470db6fea71ec12e43f86e3fd62ed6259c83a Gerrit-Change-Number: 21059 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 17:39:48 +0000 Gerrit-HasComments: Yes
