Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21063 )
Change subject: IMPALA-12834: Add number of concurrent queries to profile ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21063/2/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/21063/2/be/src/scheduling/admission-controller.h@1171 PS2, Line 1171: of the 'grp_name' executor group nit: for the given executor group http://gerrit.cloudera.org:8080/#/c/21063/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21063/2/be/src/scheduling/admission-controller.cc@189 PS2, Line 189: scheduled nit: designated ? http://gerrit.cloudera.org:8080/#/c/21063/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/21063/2/tests/custom_cluster/test_admission_controller.py@928 PS2, Line 928: nit: indent spaces -- To view, visit http://gerrit.cloudera.org:8080/21063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8389215b60022b39e7d171d6fc2418acca7c0658 Gerrit-Change-Number: 21063 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Feb 2024 17:51:13 +0000 Gerrit-HasComments: Yes