Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21035 )
Change subject: IMPALA-12818: Intermediate Result Caching plan node framework ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21035/3/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21035/3/be/src/exec/tuple-cache-node.cc@28 PS3, Line 28: allow_tuple_caching > Does that mean the allow_tuple_caching is always true when it comes to the The way I see it working is: 1. if allow_tuple_caching is false, then enable_tuple_caching is always false 2. if allow_tuple_caching is true, you can set enable_tuple_caching Enable_tuple_caching is a query option. The frontend checks for enable_tuple_caching before running the TupleCachePlanner. TupleCacheNode instances will not be created unless both allow_tuple_caching and enable_tuple_caching are true for a query. -- To view, visit http://gerrit.cloudera.org:8080/21035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f36a87dcce6efd5d1e1f0bc04009bf009b1961 Gerrit-Change-Number: 21035 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 27 Feb 2024 21:03:13 +0000 Gerrit-HasComments: Yes
