Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20850 )
Change subject: IMPALA-12533: Support row materialization outside of fetch lock ...................................................................... Patch Set 13: Code-Review+1 (6 comments) http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/codegen/llvm-codegen.cc@263 PS7, Line 263: codegen->reset(); > Done Ack http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/coordinator.cc@1050 PS7, Line 1050: results->SetCodegenPtr(coord_instance_->GetCodegenPtr()); > Changed as suggested. Done http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/fragment-state.h File be/src/runtime/fragment-state.h: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/runtime/fragment-state.h@58 PS7, Line 58: const std::shared_ptr<LlvmCodeGen>& GetCodegenPtr() const; > Changed to SetCodegenRef. I want to preserve the existing references. Done. My original comment here confused what was going on, looks clearer now. http://gerrit.cloudera.org:8080/#/c/20850/13/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/20850/13/be/src/runtime/row-batch.h@295 PS13, Line 295: /// Copy 'num_rows' rows from 'src' to 'dest' within the batch. Useful for exec Should the description be updated too? http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h File be/src/service/query-result-set.h: http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h@98 PS7, Line 98: void SetCodegenPtr(const std::shared_ptr<LlvmCodeGen>& codegen) { > This is set externally and needs to be non-const. Ack http://gerrit.cloudera.org:8080/#/c/20850/7/be/src/service/query-result-set.h@109 PS7, Line 109: /// Reference to root fragment codegen structures. Needed to allow delayed > It is set externally as a reference. Ack -- To view, visit http://gerrit.cloudera.org:8080/20850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9512aa6022dbcf81e7eb5f559853b89fe80bd23 Gerrit-Change-Number: 20850 Gerrit-PatchSet: 13 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 27 Feb 2024 22:15:00 +0000 Gerrit-HasComments: Yes
