Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10258 )
Change subject: [DOCS] Add Impala docs from branch 2.x ...................................................................... Patch Set 1: (2 comments) When I make the HTML docs from commit 9c32594f722f139955788d0da57bdeecc3bacf75 and diff -urZ the built results with the HTML docs here, I get a lot of differences. They all seem to be about some stale version numbers transitioning from 2.8.x to 2.12.x. One such hunk looks like this: https://gist.github.com/mikesbrown/cd0da5bc257c41f9220faa5436b4e1f5 What's going on there? http://gerrit.cloudera.org:8080/#/c/10258/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10258/1//COMMIT_MSG@9 PS1, Line 9: master 2.x http://gerrit.cloudera.org:8080/#/c/10258/1/docs/build/impala.pdf File docs/build/impala.pdf: http://gerrit.cloudera.org:8080/#/c/10258/1/docs/build/impala.pdf@a1 PS1, Line 1: > Removed I think you still need to push the new patch set. -- To view, visit http://gerrit.cloudera.org:8080/10258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: I4e94fb12984974e280d3c6aeab384c1021b7f76a Gerrit-Change-Number: 10258 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 18:07:38 +0000 Gerrit-HasComments: Yes
