Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21071 )

Change subject: IMPALA-12827: Fix failures in processing AbortTxnEvent due to 
aborted write id is cleaned up
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 5:
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/21071/5/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/21071/5/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@842
PS5, Line 842:       LOG.info("EventId: {} EventType: COMMIT_TXN transaction 
id: {}", getEventId(),
> Why are these (and other) messages INFO level now? This may create a lot of
These are very helpful in connecting the COMMIT/ABORT_TXN events with the 
transaction ids. Before this, the logs have no info about that and it's hard to 
debug when issue happens.

Note that we already have logs for each event. It won't introduce too many logs.



--
To view, visit http://gerrit.cloudera.org:8080/21071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b6f684d6e4b94961d804a0c022029249873681
Gerrit-Change-Number: 21071
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Wed, 28 Feb 2024 22:14:55 +0000
Gerrit-HasComments: Yes

Reply via email to