Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21059 )
Change subject: IMPALA-12426: QueryStateRecord Refactor ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/21059/13/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: http://gerrit.cloudera.org:8080/#/c/21059/13/be/src/util/runtime-profile-test.cc@95 PS13, Line 95: EXPECT_TRUE(from_thrift->GetCounter("Not there") == NULL); > Is there some reason to verify that NULL == nullptr? Implementations of GetCounter() are old and thus return NULL. The new code checks for nullptr instead of NULL. (for example https://gerrit.cloudera.org/c/21059/13/be/src/service/query-state-record.cc#261). Since NULL and nullptr are slightly different, I wanted to ensure the new code using nullptr was not going to have subtle bugs, thus these new assertions that both NULL and nullptr can be used to compare against the return from the GetCounter function. -- To view, visit http://gerrit.cloudera.org:8080/21059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d470db6fea71ec12e43f86e3fd62ed6259c83a Gerrit-Change-Number: 21059 Gerrit-PatchSet: 14 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 28 Feb 2024 22:28:23 +0000 Gerrit-HasComments: Yes
