Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21040 )
Change subject: IMPALA-12821: Fix test_create_table_profile_events depend on event-processor ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21040/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/21040/2/tests/query_test/test_observability.py@477 PS2, Line 477: test_create_table_profile_events nit: I think it is good to mention in comment that this test is expected to pass with or without event processor enabled. Feel free to add this or not, and please carry my +2. -- To view, visit http://gerrit.cloudera.org:8080/21040 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37a30c3f6cb1b396809259d365a4a2e662b9251f Gerrit-Change-Number: 21040 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 29 Feb 2024 16:11:35 +0000 Gerrit-HasComments: Yes
