Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21051 )
Change subject: IMPALA-12833: Enabled 'catalogd_ha_reset_metadata_on_failover' by default ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21051/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21051/2//COMMIT_MSG@9 PS2, Line 9: This patch set the default value of catalog server starting flag : 'catalogd_ha_reset_metadata_on_failover' as true so that catalogd : will reset its metadata when it becomes active. We could expand on the reasoning a bit, maybe: "The passive catalogd may have stale metadata (event processor could have hung or could be just behind in processing events or for some other reason) and also the passive catalog doesn't get invalidate request from coordinator so we should probably reset its metadata when it becomes active." Probably also good to put a similar comment in the code. -- To view, visit http://gerrit.cloudera.org:8080/21051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc7c529f34b70734a700ac0d9d58b7e5b0215f8d Gerrit-Change-Number: 21051 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 29 Feb 2024 20:56:55 +0000 Gerrit-HasComments: Yes
