Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21091 )
Change subject: Fix toolchain container builds for SLES 12, SLES 15 and Centos 7 ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21091/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21091/2//COMMIT_MSG@7 PS2, Line 7: Fix toolchain container builds for SLES 12, SLES 15 and Centos 7 nit: should probably have a ticket mentioning all the issues. http://gerrit.cloudera.org:8080/#/c/21091/2//COMMIT_MSG@19 PS2, Line 19: can be installed. libncurses-devel. The newest version available for Sentence fragment? Maybe libncurses-devel is supposed to come before "can be installed"? http://gerrit.cloudera.org:8080/#/c/21091/2/docker/sles12.df File docker/sles12.df: http://gerrit.cloudera.org:8080/#/c/21091/2/docker/sles12.df@12 PS2, Line 12: # RUN zypper --non-interactive in --oldpackage libncurses6-5.9-40.124.x86_64 libncurses5-5.9-40.124.x86_64 ncurses-devel-5.9-40.124.x86_64 Can we remove this line completely? -- To view, visit http://gerrit.cloudera.org:8080/21091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e730abb6667bf00735ea62c35377591b68452ce Gerrit-Change-Number: 21091 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 29 Feb 2024 21:09:07 +0000 Gerrit-HasComments: Yes
