Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10243 )
Change subject: IMPALA-6882: prevent instr. hoist from CpuInfo::IsSupported() ...................................................................... Patch Set 3: This is fine with me. But did we consider adding CompilerBarrier() to IsSupported() to deal with the issue in general? That would be conservative, but in the cases where the barrier is not needed, it also means it's not a fast-path... -- To view, visit http://gerrit.cloudera.org:8080/10243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ec51bdfcb9455c93ff69827929a59fcccb81b80 Gerrit-Change-Number: 10243 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 19:06:19 +0000 Gerrit-HasComments: No
