Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 )
Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10265/1/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/10265/1/be/src/rpc/thrift-util.cc@209 PS1, Line 209: strncmp(PACKAGE_VERSION, "0.9.0", 5)); > Since this patch is only in 2.x, I think we don't need to have this as thri Don't you mean strncmp() == 0? Why didn't testing catch that? -- To view, visit http://gerrit.cloudera.org:8080/10265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I1bb997a833917e5166c9ca192da219f50f4439e2 Gerrit-Change-Number: 10265 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 19:18:14 +0000 Gerrit-HasComments: Yes
