Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21086 )
Change subject: IMPALA-12849: Standby catalogd should reject requests from coordinators ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21086/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21086/2//COMMIT_MSG@10 PS2, Line 10: could receive requests from coordinators in a short window after manual maybe we should remove "manual" as this is also possible when failover happens in general for any reason such as network connectivity issue between statestore and catalog or catalog restarting for whatever reasons, etc? http://gerrit.cloudera.org:8080/#/c/21086/2//COMMIT_MSG@16 PS2, Line 16: This patchs checks if the catalog server is active when handling request typo: 'patchs' - > 'patch' http://gerrit.cloudera.org:8080/#/c/21086/2/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/21086/2/be/src/catalog/catalog-server.cc@419 PS2, Line 419: "catalogd $0 is inactive", server_address_)); Maybe "stand-by" or "passive" is the right terminology here? -- To view, visit http://gerrit.cloudera.org:8080/21086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea38bdf4f207af657e71670a572efc7c0a0ba807 Gerrit-Change-Number: 21086 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 05 Mar 2024 21:54:35 +0000 Gerrit-HasComments: Yes
