[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21065 )
Change subject: [WIP]IMPALA-12832: Implicit invalidate metadata on event failures ...................................................................... Patch Set 16: (3 comments) Replies to comments on patchset-11 http://gerrit.cloudera.org:8080/#/c/21065/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21065/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2753 PS3, Line 2753: etTable( > Could you explain more why we don't invalidate tables for CreateTable event Currently create table event process can fail due to DatabaseNotFoundException checked exception other than unchecked/runtime exceptions. Probably because database is dropped from impala just before the create table event is processed. Let assume database is recreated again(from hive) after this create table event is generated but before processing the event. If we do invalidateTable() on CreateTable failure, we endup creating catalog database object and table object at this point. Ideally this create table should not be created. And create database event is somewhere behind in the notification log. We can discuss create table event onFailure in another jira. http://gerrit.cloudera.org:8080/#/c/21065/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21065/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1287 PS11, Line 1287: if (isInvalidate) { > Let's trim the name strings in case of bugs like IMPALA-11939 No other events have trim currently. We would have to consider for all the events. Shall consider it in another jira. http://gerrit.cloudera.org:8080/#/c/21065/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/21065/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1012 PS11, Line 1012: LOG.error("Automatic global invalidate metadata failed", e); > Shouldn't we re-throw the exception? Not throwing exception because it kills the thread and creates again -- To view, visit http://gerrit.cloudera.org:8080/21065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia67fc04c995802d3b6b56f79564bf0954b012c6c Gerrit-Change-Number: 21065 Gerrit-PatchSet: 16 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 06 Mar 2024 07:20:06 +0000 Gerrit-HasComments: Yes
