Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21113 )
Change subject: PROTOTYPE (IMPALA-9153): Vendor CZT's cup-maven-plugin ...................................................................... Patch Set 1: (118 comments) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java File java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java: http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@54 PS1, Line 54: * Goal which generates parser source files from the given CUP parser specifications (*.cup). line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@61 PS1, Line 61: @Mojo(name = "generate", threadSafe = false, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@65 PS1, Line 65: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@67 PS1, Line 67: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@71 PS1, Line 71: @Parameter( property = "cup.sourceDirectory", defaultValue = "${project.basedir}/src/main/cup" ) line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@80 PS1, Line 80: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@84 PS1, Line 84: * Specify that the parser and sym classes are to be placed in the named package. By default, no line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@85 PS1, Line 85: * package specification is put in the generated code (hence the classes default to the special line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@91 PS1, Line 91: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@95 PS1, Line 95: * Output parser and action code into a file (and class) with the given name. If not given, CUP line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@101 PS1, Line 101: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@107 PS1, Line 107: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@111 PS1, Line 111: * Output the symbol constant code into a class with the given name instead of the default of line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@119 PS1, Line 119: * Outputs the symbol constant code as an {@code interface} rather than as a {@code class}. line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@123 PS1, Line 123: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@125 PS1, Line 125: * Place constants for non-terminals into the symbol constant class. The parser does not need line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@126 PS1, Line 126: * these symbol constants, so they are not normally output. However, it can be very helpful to line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@131 PS1, Line 131: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@133 PS1, Line 133: * During parser construction the system may detect that an ambiguous situation would occur at line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@134 PS1, Line 134: * runtime. This is called a conflict. In general, the parser may be unable to decide whether to line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@135 PS1, Line 135: * shift (read another symbol) or reduce (replace the recognized right hand side of a production line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@136 PS1, Line 136: * with its left hand side). This is called a shift/reduce conflict. Similarly, the parser may not line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@138 PS1, Line 138: * reduce/reduce conflict. Normally, if one or more of these conflicts occur, parser generation is line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@139 PS1, Line 139: * aborted. However, in certain carefully considered cases it may be advantageous to arbitrarily line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@140 PS1, Line 140: * break such a conflict. In this case CUP uses YACC convention and resolves shift/reduce line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@141 PS1, Line 141: * conflicts by shifting, and reduce/reduce conflicts using the "highest priority" production (the line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@142 PS1, Line 142: * one declared first in the specification). In order to enable automatic breaking of conflicts line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@143 PS1, Line 143: * the -expect option must be given indicating exactly how many conflicts are expected. Conflicts line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@148 PS1, Line 148: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@150 PS1, Line 150: * Including this option enables a table compaction optimization involving reductions. In line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@151 PS1, Line 151: * particular, it allows the most common reduce entry in each row of the parse action table to be line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@152 PS1, Line 152: * used as the default for that row. This typically saves considerable room in the tables, which line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@153 PS1, Line 153: * can grow to be very large. This optimization has the effect of replacing all error entries in a line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@154 PS1, Line 154: * row with the default reduce entry. While this may sound dangerous, if not down right incorrect, line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@155 PS1, Line 155: * it turns out that this does not affect the correctness of the parser. In particular, some line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@156 PS1, Line 156: * changes of this type are inherent in LALR parsers (when compared to canonical LR parsers), and line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@157 PS1, Line 157: * the resulting parsers will still never read past the first token at which the error could be line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@158 PS1, Line 158: * detected. The parser can, however, make extra erroneous reduces before detecting the error, so line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@159 PS1, Line 159: * this can degrade the parser's ability to do error recovery. (Refer to reference [2] pp. 244-247 line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@160 PS1, Line 160: * or reference [3] pp. 190-194 for a complete explanation of this compaction technique.) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@163 PS1, Line 163: * initialization code sizes. However, CUP 0.10h introduced a string-encoding for the parser line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@164 PS1, Line 164: * tables which is not subject to the standard method-size limitations. Consequently, use of this line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@176 PS1, Line 176: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@178 PS1, Line 178: * Suppress printing a summary listing such things as the number of terminals, non-terminals, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@185 PS1, Line 185: * Print short messages indicating progress through various parts of the parser generation line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@190 PS1, Line 190: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@192 PS1, Line 192: * Output a human readable dump of the grammar. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@196 PS1, Line 196: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@198 PS1, Line 198: * Output a human readable dump of the constructed parse states (often needed to resolve parse line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@209 PS1, Line 209: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@215 PS1, Line 215: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@221 PS1, Line 221: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@223 PS1, Line 223: * Do not generate code to propagate the left and right hand values of terminals to non-terminals, line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@224 PS1, Line 224: * and then from non-terminals to other terminals. If the left and right values aren't going to be line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@225 PS1, Line 225: * used by the parser, then it will save some runtime computation to not generate these position line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@226 PS1, Line 226: * propagations. This option also keeps the left and right label variables from being generated, line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@231 PS1, Line 231: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@236 PS1, Line 236: * {@link java_cup.runtime.Scanner}. By default, the generated parser refers to this interface, line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@237 PS1, Line 237: * which means you cannot use these parsers with CUP runtimes older than 0.10j. If your parser line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@239 PS1, Line 239: * {@link java_cup.runtime.Scanner} references and allow compatibility with old runtimes. Not many line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@245 PS1, Line 245: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@249 PS1, Line 249: * The external parser tables are normally encoded in the generated parser file. This option line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@254 PS1, Line 254: * If the parser tables are too large, they are always written to an external file, despite line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@255 PS1, Line 255: * this option here. This is to avoid "code too large" Java compilation errors, caused by line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@262 PS1, Line 262: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@266 PS1, Line 266: * CUP produces generic Java code, some of which doesn't get used. For instance, the left/right line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@267 PS1, Line 267: * integer location information for every terminal in productions are always generated, even if line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@268 PS1, Line 268: * they are never used. This creates a series of unused warnings that need removing. Another line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@268 PS1, Line 268: * they are never used. This creates a series of unused warnings that need removing. Another line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@269 PS1, Line 269: * example is when some of the terminal symbols contain elements with generic types. This creates line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@270 PS1, Line 270: * unchecked warnings at various places where such generic non-terminal types appear. At this line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@270 PS1, Line 270: * unchecked warnings at various places where such generic non-terminal types appear. At this line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@271 PS1, Line 271: * stage it is needed to add an unchecked cast warning suppression. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@274 PS1, Line 274: * By default this flag is false, and all warnings are added. If set to true, our specific warning line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@275 PS1, Line 275: * suppression is added instead. Warning suppression is added locally, so as to not hide any dead line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@279 PS1, Line 279: @Parameter( property = "cup.suppressGeneratedJavaWarningsUnchecked", defaultValue = "false" ) line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@281 PS1, Line 281: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@285 PS1, Line 285: * Suppress any unused code warnings from CUP action class globally. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@289 PS1, Line 289: @Parameter( property = "cup.suppressGeneratedJavaWarningsUnused", defaultValue = "false" ) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@291 PS1, Line 291: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@297 PS1, Line 297: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@315 PS1, Line 315: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@324 PS1, Line 324: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@327 PS1, Line 327: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@332 PS1, Line 332: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@334 PS1, Line 334: * Collects CUP files in the source directory (changed files only for incremental builds). line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@335 PS1, Line 335: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@339 PS1, Line 339: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@344 PS1, Line 344: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@349 PS1, Line 349: // line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@355 PS1, Line 355: // line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@357 PS1, Line 357: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@364 PS1, Line 364: List<File> changed = new ArrayList<File>(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@365 PS1, Line 365: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@371 PS1, Line 371: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@374 PS1, Line 374: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@388 PS1, Line 388: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@392 PS1, Line 392: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@430 PS1, Line 430: throw new MojoExecutionException("Couldn't create directories for " + destDir.getName()); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@430 PS1, Line 430: throw new MojoExecutionException("Couldn't create directories for " + destDir.getName()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@532 PS1, Line 532: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@536 PS1, Line 536: // refresh generated external parser tables (*.dat files) tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@537 PS1, Line 537: for (File resourceFile : listFiles) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@538 PS1, Line 538: if (resourceFile.getName().endsWith(".dat")) { tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@539 PS1, Line 539: refreshFile(resourceFile); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@540 PS1, Line 540: } tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@541 PS1, Line 541: } tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@545 PS1, Line 545: throw new MojoExecutionException("Couldn't get destination directory list of files - " + destDir.getName()); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@545 PS1, Line 545: throw new MojoExecutionException("Couldn't get destination directory list of files - " + destDir.getName()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@551 PS1, Line 551: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@558 PS1, Line 558: //FileReader fl = new FileReader(cupFile);; avoid default encoding tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@560 PS1, Line 560: new InputStreamReader(new FileInputStream(cupFile), StandardCharsets.US_ASCII)); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@583 PS1, Line 583: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@589 PS1, Line 589: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@605 PS1, Line 605: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@608 PS1, Line 608: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@618 PS1, Line 618: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21113/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@622 PS1, Line 622: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfea0154465bb2baf6f5dd8033a3717ee55083fc Gerrit-Change-Number: 21113 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2024 06:56:35 +0000 Gerrit-HasComments: Yes
