Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21029 )
Change subject: IMPALA-12543: Detect self-events before finishing DDL ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/21029/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21029/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1090 PS13, Line 1090: markInflightEventRegistrationComplete(); Can this function be modified to be called multiple times by removing the precondition? http://gerrit.cloudera.org:8080/#/c/21029/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1393 PS13, Line 1393: if (modification.hasInflightEventRegistration()) modification.cancelInflightEvent(); This pattern of checking hasInflightEventRegistration followed by calling cancelInflightEvent is repeated several times. The comment on cancelInflightEvent indicates there could be multiple threads calling cancelInflightEvent at the same time. If that is the case, there is a potential with this pattern to fail the precondition check where another thread calls cancelInflightEvent before the code here calls it since this pattern is not an atomic operation. Can the cancelInflightEvent function be modified to be called multiple times? -- To view, visit http://gerrit.cloudera.org:8080/21029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8365c934349ad21a4d9327fc11594d2fc3445f79 Gerrit-Change-Number: 21029 Gerrit-PatchSet: 13 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 07 Mar 2024 16:01:32 +0000 Gerrit-HasComments: Yes
