Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10060 )
Change subject: [Preview]IMPALA-5216: Make admission control queuing async ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/10060/2/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/10060/2/be/src/scheduling/admission-controller.h@395 PS2, Line 395: > Did you miss updating this one? I had updated the comment above QueueNode about the ownership of both schedule and admit_outcome http://gerrit.cloudera.org:8080/#/c/10060/4/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/10060/4/be/src/scheduling/admission-controller.cc@599 PS4, Line 599: timed_out > Inline this expression into the if() below so that the symmetry with the el Done http://gerrit.cloudera.org:8080/#/c/10060/4/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/10060/4/be/src/service/impala-http-handler.cc@769 PS4, Line 769: NULL > nullptr Done http://gerrit.cloudera.org:8080/#/c/10060/4/be/src/service/impala-http-handler.cc@778 PS4, Line 778: NULL > nullptr Done http://gerrit.cloudera.org:8080/#/c/10060/4/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/10060/4/tests/custom_cluster/test_admission_controller.py@480 PS4, Line 480: except (Exception) as e: > parens around Exception not needed? Done http://gerrit.cloudera.org:8080/#/c/10060/4/tests/custom_cluster/test_admission_controller.py@493 PS4, Line 493: class TestAdmissionControllerStress(TestAdmissionControllerBase): > I'm seeing some of these tests fail when run locally on my system - not sur Done -- To view, visit http://gerrit.cloudera.org:8080/10060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10060 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 22:10:48 +0000 Gerrit-HasComments: Yes
