Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21125 )
Change subject: IMPALA-12611: Add support to MAP type Iceberg Metadata table columns ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/21125/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h File be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h: http://gerrit.cloudera.org:8080/#/c/21125/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h@139 PS1, Line 139: Status GetNextCollectionScannerItem(JNIEnv* env, const jobject& scanner, jobject* result) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21125/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc File be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc: http://gerrit.cloudera.org:8080/#/c/21125/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc@64 PS1, Line 64: "(Ljava/util/List;)Lorg/apache/impala/util/IcebergMetadataScanner$CollectionScanner;", line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21125/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc@68 PS1, Line 68: "(Ljava/util/Map;)Lorg/apache/impala/util/IcebergMetadataScanner$CollectionScanner;", line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21125/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc@220 PS1, Line 220: Status IcebergMetadataScanner::CreateArrayOrMapScanner(JNIEnv* env, const jobject &list_or_map, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21125/1/be/src/exec/iceberg-metadata/iceberg-row-reader.h File be/src/exec/iceberg-metadata/iceberg-row-reader.h: http://gerrit.cloudera.org:8080/#/c/21125/1/be/src/exec/iceberg-metadata/iceberg-row-reader.h@80 PS1, Line 80: Status WriteSlot(JNIEnv* env, const jobject* struct_like_row, const jobject& accessed_value, line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a8b3a574ca45c893315c3b41b33ce4e0eff865a Gerrit-Change-Number: 21125 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 08 Mar 2024 14:02:59 +0000 Gerrit-HasComments: Yes
