Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21019 )
Change subject: IMPALA-12487: Skip reloading file metadata for ALTER_TABLE events with trivial changes in StorageDescriptor ...................................................................... Patch Set 2: > Patch Set 2: > > (2 comments) > > Skip reloading file metadata looks good to me. But I'm uncertain whether skip > reloading table schema is safe. Maybe we should compare the whole msTable > object instead of just checking several fields. Comparing the whole msTable object is not ideal because certain fields like change columns, change owner, may require required table metadata reload but certain other properties in serde like change location, and change row/file format don't need table metadata reload. This is much more evident when we use this patch in conjunction with IMPALA-10976. -- To view, visit http://gerrit.cloudera.org:8080/21019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fd9a9504bf93d2529dc7accbf436ad83e51d8ac Gerrit-Change-Number: 21019 Gerrit-PatchSet: 2 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Mar 2024 22:34:37 +0000 Gerrit-HasComments: No
