Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 41: (1 comment) http://gerrit.cloudera.org:8080/#/c/20770/41/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/20770/41/tests/util/workload_management.py@259 PS41, Line 259: root_mem = re.search(r'\nPLAN-ROOT SINK.*?mem-estimate=(\S+?) mem-reservation', This doesn't work when I try to write tests using some existing tables, like 'select * from functional.alltypes'. I ended up modifying it to root_mem = re.search( r'\n\nF\d+:PLAN FRAGMENT.*?mem-estimate=(\S+?) mem-reservation', profile_text, re.DOTALL) There's a fragment above PLAN-ROOT SINK, and I suspect that's what we actually want. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 41 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 12 Mar 2024 00:03:59 +0000 Gerrit-HasComments: Yes
