Joe McDonnell has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/21111 )

Change subject: IMPALA-12689: Change TPC-H and TPC-DS builds to respect CFLAGS
......................................................................

IMPALA-12689: Change TPC-H and TPC-DS builds to respect CFLAGS

The TPC-H and TPC-DS builds currently do not respect the
CFLAGS environment variable, so they don't incorporate the
values that we set in init-compiler.sh.

This modifies the build scripts for TPC-H and TPC-DS to
patch their makefiles to add our CFLAGS. This has the
side effect of turning on -O3 optimization, resulting
in faster binaries used to generate the TPC-H and
TPC-DS datasets:

TPC-H's dbgen at scale 42:
Unoptimized: 4m46.269s
Optimized: 3m46.379s

TPC-DS's dsdgen at scale 20:
Unoptimized: 9m41.441s
Optimized: 7m25.017s

Testing:
 - Ran a build and verified that the flags include our
   CFLAGS value

Change-Id: I3f999b71c56a72c14f1beeea99a3689b82a4d45a
Reviewed-on: http://gerrit.cloudera.org:8080/21111
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Joe McDonnell <[email protected]>
---
M source/tpc-ds/build.sh
M source/tpc-h/build.sh
2 files changed, 14 insertions(+), 0 deletions(-)

Approvals:
  Michael Smith: Looks good to me, approved
  Joe McDonnell: Verified

--
To view, visit http://gerrit.cloudera.org:8080/21111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f999b71c56a72c14f1beeea99a3689b82a4d45a
Gerrit-Change-Number: 21111
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>

Reply via email to