Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21141 )
Change subject: IMPALA-12896: Avoid JDBC table to be set as transactional table ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21141/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/21141/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@809 PS1, Line 809: Exception > IOException is subclass of Exception. We found the exception was not catche nit: I'd suggest to narrow it down to subclass of Exception that is actually thrown, but I guess this is fine too to catch all. http://gerrit.cloudera.org:8080/#/c/21141/2/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/21141/2/tests/custom_cluster/test_ext_data_sources.py@29 PS2, Line 29: : class TestExtDataSources(CustomClusterTestSuite): : """Impala query tests for external data sources.""" You can add_test_dimension to apply exec_single_node_rows_threshold = 100 for all tests here. from tests.common.test_dimensions import create_exec_option_dimension ... @classmethod def add_test_dimensions(cls): super(TestExtDataSources, cls).add_test_dimensions() cls.ImpalaTestMatrix.add_dimension(create_exec_option_dimension( exec_single_node_option=[100])) Similarly for TestImpalaExtJdbcTables. L52 and L254 then can be removed. -- To view, visit http://gerrit.cloudera.org:8080/21141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I556faeda923a4a11d4bef8c1250c9616f77e6fa6 Gerrit-Change-Number: 21141 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 12 Mar 2024 23:12:11 +0000 Gerrit-HasComments: Yes
