Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20921 )
Change subject: IMPALA-12362: (part-1/4) Refactor service management scripts. ...................................................................... Patch Set 10: (2 comments) Very useful feature, thanks for working on this! http://gerrit.cloudera.org:8080/#/c/20921/10/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/20921/10/package/bin/impala.sh@67 PS10, Line 67: kill $pid It would be better if we had a 'wait_for_stop' called here to ensure that the process has indeed ended before we proceed. Something like this maybe work: while kill -0 $pid > /dev/null 2>&1; do sleep 1 done http://gerrit.cloudera.org:8080/#/c/20921/10/package/bin/impala.sh@120 PS10, Line 120: sleep 1 The original script had a 'wait_for_ready' following this to wait for the completion of the service startup. It now seems to have been replaced with 'health'. Should we also call 'health' here to ensure the service has started properly? -- To view, visit http://gerrit.cloudera.org:8080/20921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f4dcad9cfa12d351d562e7ef8c0a8957d3ca147 Gerrit-Change-Number: 20921 Gerrit-PatchSet: 10 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2024 07:39:27 +0000 Gerrit-HasComments: Yes
