Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 51: (2 comments) http://gerrit.cloudera.org:8080/#/c/20770/50/be/src/service/workload-management-fields.cc File be/src/service/workload-management-fields.cc: http://gerrit.cloudera.org:8080/#/c/20770/50/be/src/service/workload-management-fields.cc@59 PS50, Line 59: corresponding misspelling fixed http://gerrit.cloudera.org:8080/#/c/20770/49/tests/util/workload_management.py File tests/util/workload_management.py: http://gerrit.cloudera.org:8080/#/c/20770/49/tests/util/workload_management.py@277 PS49, Line 277: query_opts = re.search(r'\n\s+Query Options \(set by configuration\):\s+(.*?)\n', > nit: sql_stmt doesn't seem like the right variable name Nope. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 51 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 15 Mar 2024 15:25:25 +0000 Gerrit-HasComments: Yes
