Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21152 )
Change subject: IMPALA-12914: TestBannedLogMessages no longer requires running cluster ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21152/2/tests/verifiers/test_banned_log_messages.py File tests/verifiers/test_banned_log_messages.py: http://gerrit.cloudera.org:8080/#/c/21152/2/tests/verifiers/test_banned_log_messages.py@24 PS2, Line 24: : class TestBannedLogMessages: nit: This can inherit BaseTestSuite from ./tests/common/base_test_suite.py. But since it does not use any test dimension, this one is OK too. -- To view, visit http://gerrit.cloudera.org:8080/21152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfa7d5925bf724d714eaa7fa606defae0822cf93 Gerrit-Change-Number: 21152 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 15 Mar 2024 21:16:00 +0000 Gerrit-HasComments: Yes
