Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21153 )
Change subject: IMPALA-12913: Refactor Workload Management Custom Cluser Tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21153/1/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/21153/1/testdata/datasets/functional/functional_schema_template.sql@1804 PS1, Line 1804: CREATE EXTERNAL TABLE IF NOT EXISTS {db_name}{db_suffix}.{table_name} ( There seem to be support for all this above with COLUMNS, ROW_FORMAT, DEPENDENT_LOAD. Why use CREATE instead? http://gerrit.cloudera.org:8080/#/c/21153/1/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21153/1/tests/custom_cluster/test_query_log.py@438 PS1, Line 438: client = self.create_impala_client(protocol=vector.get_value('protocol')) Why do you create a client? I guess there are clients already set up, but selecting the correct one isn't easy (unless using "run_test_case"). Might be useful to add a test helper to get the existing client for a protocol instead of creating new ones. -- To view, visit http://gerrit.cloudera.org:8080/21153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3249a8f306cf43de0d6f6586711c779399e83b Gerrit-Change-Number: 21153 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Mar 2024 23:49:02 +0000 Gerrit-HasComments: Yes