Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21109 )
Change subject: IMPALA-12872: Use Calcite for ... ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21109/5/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/21109/5/fe/pom.xml@616 PS5, Line 616: <dependency> : <groupId>org.apache.calcite</groupId> : <artifactId>calcite-core</artifactId> : <version>1.36.0</version> : </dependency> : <dependency> : <groupId>org.apache.calcite.avatica</groupId> : <artifactId>avatica-core</artifactId> : <version>1.23.0</version> : </dependency> > I think fe doesn't actually need these dependencies, and they could be decl Yeah. This was an interesting dilemma for me I put this in the fe/pom.xml because it made my life slightly easier. Eventually we should put this Calcite code under fe and this would be the place it would go. But by having it under the "java" subdirectory, it means that the jar files from Calcite won't be in the main target directory. So I would either have to come up with a build mechanism under the java file with its own "target" dir that contains all the dependent jar files or shade them into the Impala Calcite jar file. And this would only be presumably temporary. But it does make sense to do it this way because otherwise we are putting Calcite in the distribution when we are not really using it. Given all this, how do you think I should handle it? -- To view, visit http://gerrit.cloudera.org:8080/21109 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I453fd75b7b705f4d7de1ed73c3e24cafad0b8c98 Gerrit-Change-Number: 21109 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 18 Mar 2024 17:12:30 +0000 Gerrit-HasComments: Yes
