Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20770 )
Change subject: IMPALA-12426: Query History Table ...................................................................... Patch Set 53: (2 comments) http://gerrit.cloudera.org:8080/#/c/20770/52/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/20770/52/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@422 PS52, Line 422: initialHmsCnxnTimeoutSec)); : } > That makes sense. It's not used in any static functions, and static initial Done http://gerrit.cloudera.org:8080/#/c/20770/52/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@444 PS52, Line 444: return !impalaSysTables.contains(table.getTbl()); > My next commit adds another item to impalaSysTables. I left the variable in place and moved its initialization to the class constructor. -- To view, visit http://gerrit.cloudera.org:8080/20770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d2da9d450fba4e789400cfa62927fc25d34f844 Gerrit-Change-Number: 20770 Gerrit-PatchSet: 53 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Mar 2024 17:04:15 +0000 Gerrit-HasComments: Yes
