Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21168 )

Change subject: IMPALA-12920: Support ai_generate_text built-in function for 
OpenAI's chat completion API
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/21168/1/be/src/exprs/ai-functions-ir.cc
File be/src/exprs/ai-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/21168/1/be/src/exprs/ai-functions-ir.cc@178
PS1, Line 178:    << ", offset input " << overrides.GetErrorOffset();
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/21168/1/be/src/exprs/ai-functions-ir.cc@187
PS1, Line 187:  } else {
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/21168/1/be/src/exprs/ai-functions-ir.cc@189
PS1, Line 189:  }
tab used for whitespace


http://gerrit.cloudera.org:8080/#/c/21168/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/21168/1/be/src/exprs/expr-test.cc@11295
PS1, Line 11295:       ctx, StringVal::null(), prompt, StringVal::null(), 
jceks_secret, json_params, dry_run);
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21168/1/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

http://gerrit.cloudera.org:8080/#/c/21168/1/be/src/runtime/exec-env.cc@512
PS1, Line 512:     Status status = 
frontend_->GetSecretFromKeyStore(FLAGS_ai_api_key_jceks_secret, &api_key);
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/21168
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4446957f6030bab1f985fdd69185c3da07d7c4b
Gerrit-Change-Number: 21168
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Tue, 19 Mar 2024 21:34:11 +0000
Gerrit-HasComments: Yes

Reply via email to