Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20886 )
Change subject: IMPALA-12626: Add Tables Queried to profile/history ...................................................................... Patch Set 25: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20886/25/be/src/util/debug-util.cc File be/src/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/20886/25/be/src/util/debug-util.cc@287 PS25, Line 287: } Nit: this may be cleaner if re-written using a pattern I have seen elsewhere in your code: for (auto const& tbl : tbls) { ss << tbl->db_name << "." << tbl->table_name << ","; } return ss.str().pop_back(); -- To view, visit http://gerrit.cloudera.org:8080/20886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c9c80b2adf7f3e44225a191fe8eb9df3c4bc5aa Gerrit-Change-Number: 20886 Gerrit-PatchSet: 25 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2024 17:55:33 +0000 Gerrit-HasComments: Yes
