Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21161 )
Change subject: IMPALA-12915: Build shared library of GTest ...................................................................... Patch Set 1: (1 comment) We've got a couple things in flight. This change to build shared libraries for gtest makes sense. Laszlo has a change to bump the googletest version here: https://gerrit.cloudera.org/#/c/21133/ (with a corresponding Impala change to switch to the new version). We should do an equivalent thing for source/googletest/build.sh, but that might fit better in Laszlo's change. http://gerrit.cloudera.org:8080/#/c/21161/1/source/gtest/build.sh File source/gtest/build.sh: http://gerrit.cloudera.org:8080/#/c/21161/1/source/gtest/build.sh@42 PS1, Line 42: -DBUILD_STATIC_LIBS=ON Nit: BUILD_STATIC_LIBS doesn't do anything. The default is to build static libraries and BUILD_STATIC_LIBS is ignored as a unknown variable. (It doesn't cause any harm though.) -- To view, visit http://gerrit.cloudera.org:8080/21161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie34023fe4fb0691fbca1dc547d1e40ada1beca22 Gerrit-Change-Number: 21161 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Mar 2024 00:55:31 +0000 Gerrit-HasComments: Yes
