Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10165 )
Change subject: IMPALA-6941: load more text scanner compression plugins ...................................................................... Patch Set 7: (1 comment) Thanks for applying the changes! http://gerrit.cloudera.org:8080/#/c/10165/6/be/src/exec/hdfs-plugin-text-scanner.cc File be/src/exec/hdfs-plugin-text-scanner.cc: http://gerrit.cloudera.org:8080/#/c/10165/6/be/src/exec/hdfs-plugin-text-scanner.cc@42 PS6, Line 42: : > I briefly summarized what the plugin does (versus the builtin text parsing) I was only thinking about the format of the option string. When I see a list parameter, I'm always wondering how to specify it, e.g. what separator character should I use. That's why I said that maybe we could mention in the help text, that it is comma-separated. If you think it's not necessary because we always use comma-separated lists, then that's OK. -- To view, visit http://gerrit.cloudera.org:8080/10165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2a9c4a4a11bed81df706e9e834400bfedfe48e6 Gerrit-Change-Number: 10165 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 03 May 2018 16:49:28 +0000 Gerrit-HasComments: Yes
