Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21191 )
Change subject: IMPALA-12564: Prevent Hive loading libfesupport.so in the minicluster during TSAN runs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21191/2/testdata/bin/run-hive-server.sh File testdata/bin/run-hive-server.sh: http://gerrit.cloudera.org:8080/#/c/21191/2/testdata/bin/run-hive-server.sh@169 PS2, Line 169: if [[ ! ${SKIP_LOADING_LIBFESUPPORT_IN_HIVE} ]]; then This check is always false. What we want is either: if ! $SKIP_LOADING_LIBFESUPPORT_IN_HIVE ; then or if [[ "$SKIP_LOADING_LIBFESUPPORT_IN_HIVE" != "true" ]]; then We'll have a problem if SKIP_LOADING_LIBFESUPPORT_IN_HIVE is not set as that will trip up the "set -euo pipefail" above. So, running this from a place other than buildall.sh is a problem (and developers do that). One thing we could do is look at the ${IMPALA_HOME}/.cmake_build_type file (produced by our CMake build) and see if it contains TSAN. We use that file from tests/common/environ.py to determine the build type. if ! grep -q "TSAN" ${IMPALA_HOME}/.cmake_build_type ; then The file would definitely exist for automated test jobs, and if it doesn't exist, the code would just go ahead and add libfesupport.so. -- To view, visit http://gerrit.cloudera.org:8080/21191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie030d9876c297d6e9dae80eba37e525ee2bccb20 Gerrit-Change-Number: 21191 Gerrit-PatchSet: 2 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Sat, 23 Mar 2024 00:47:29 +0000 Gerrit-HasComments: Yes
