Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21153 )
Change subject: IMPALA-12913: Refactor Workload Management Custom Cluster Tests ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/21153/6/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21153/6/tests/custom_cluster/test_query_log.py@51 PS6, Line 51: cls.PROTOCOL_BEESWAX, cls.PROTOCOL_HS2)) I wouldn't expect any difference in behavior between Beeswax and HS2, from the frontend these are very standard queries. Was there a specific reason to do both? http://gerrit.cloudera.org:8080/#/c/21153/6/tests/custom_cluster/test_query_log.py@97 PS6, Line 97: handle = client.execute_async("select '{0}'".format(rand_long_str)) Could you comment that we use async to avoid fetching the large result string. http://gerrit.cloudera.org:8080/#/c/21153/6/tests/custom_cluster/test_query_log.py@383 PS6, Line 383: def test_query_log_table_create_table_sys_db_blocked(self, vector): This isn't specific to query_log, could we move the sys db tests to a new file? http://gerrit.cloudera.org:8080/#/c/21153/7/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21153/7/tests/custom_cluster/test_query_log.py@208 PS7, Line 208: sleep(1) Why do you sleep between runs? http://gerrit.cloudera.org:8080/#/c/21153/7/tests/custom_cluster/test_query_log.py@214 PS7, Line 214: sleep(10) What are you actually waiting on. Is there a data-cache metric we can watch for this? -- To view, visit http://gerrit.cloudera.org:8080/21153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3249a8f306cf43de0d6f6586711c779399e83b Gerrit-Change-Number: 21153 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2024 16:58:02 +0000 Gerrit-HasComments: Yes
