Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21190 )

Change subject: IMPALA-12894: (part 2) Fix optimized count(*) for Iceberg 
tables with dangling delete files
......................................................................


Patch Set 5:

(2 comments)

Thanks for the comments

http://gerrit.cloudera.org:8080/#/c/21190/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21190/3//COMMIT_MSG@10
PS3, Line 10: files. Dangling delete files are delete files that are part of the
> Could you describe the cause of the bug in more detail?
Added a few extra sentences


http://gerrit.cloudera.org:8080/#/c/21190/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/21190/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@983
PS3, Line 983: don
> Nit: superfluous "use".
Done



--
To view, visit http://gerrit.cloudera.org:8080/21190
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3aca0b0a104f9ca4589cde9643f3f341d4ff99f
Gerrit-Change-Number: 21190
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Mar 2024 09:32:02 +0000
Gerrit-HasComments: Yes

Reply via email to