Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20762 )
Change subject: IMPALA-12540: Query Live Table ...................................................................... Patch Set 53: (1 comment) http://gerrit.cloudera.org:8080/#/c/20762/53/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20762/53/be/src/scheduling/cluster-membership-mgr.cc@181 PS53, Line 181: for (const auto& it : current_backends) { : if (is_active_coordinator(it.second)) { : VLOG_QUERY << "Found coordinator " : << it.second.address().hostname() << ":" << it.second.address().port(); : coordinators.emplace_back(FromNetworkAddressPB(it.second.address())); : } : } > nit: What if this simply loop return value of GetCoordinators()? I didn't want to make the extra copies of BackendDescriptorPB that would take. I could make a helper that takes a callback function to do something with the results, but for/is_active_coordinator seemed simple enough. -- To view, visit http://gerrit.cloudera.org:8080/20762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f9a449f0e5502078931e7f1c5df6e0b762c743 Gerrit-Change-Number: 20762 Gerrit-PatchSet: 53 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 27 Mar 2024 21:42:53 +0000 Gerrit-HasComments: Yes
