Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21149 )
Change subject: IMPALA-12729: Allow creating primary keys for Iceberg tables ...................................................................... Patch Set 9: After a rebase with master some Iceberg metadata table scanning tests broke. Apparently, this patch collides with the Array col querying from metadata tables resulting a Precondition check fail in TupleDescriptor.getNumNullBits(). The reason apparently, is that a struct is expected to be nullable. However, now with this change when in SlotDescriptor.setPath() I update the nullability flag, for metadata tables all the IcebergColumns will be not nullable. The IcebergColumns nullability comes from the Iceberg Schema for metadata tables from the Iceberg lib, and apparently e.g. partitions.partition is a struct but also not nullable and this gets caught byt the mentioned precondition. As a workaround I set all the metadata table cols nullable. Since we don't write these this causes no harm. -- To view, visit http://gerrit.cloudera.org:8080/21149 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bea787acdabd8cb04661f4ddb5c3309af0364a6 Gerrit-Change-Number: 21149 Gerrit-PatchSet: 9 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 28 Mar 2024 08:34:36 +0000 Gerrit-HasComments: No
