Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21186 )
Change subject: IMPALA-12933: Avoid fetching unneccessary events of unwanted types ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/21186/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21186/4//COMMIT_MSG@26 PS4, Line 26: default skip list. Such events are the most common unused events for > We don't cache such events. I mean Impala only loads the table level column Ack http://gerrit.cloudera.org:8080/#/c/21186/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/21186/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@348 PS7, Line 348: CatalogServiceCatalog catalog, long eventId, String eventType, >From the name of the method, it is intuitive that we want to fetch next >metastore events in batches from a given event id but we are now adding single >event type to the function, which means we would like to fetch metastore >events of a particular type. Even though we are currently using this method to >fetch single event type, I think we might have to have fetch a group of events >using this API. So, I think it makes sense to make the eventType as a List instead of single event or change the method name to specify that we fetch events of single event type. -- To view, visit http://gerrit.cloudera.org:8080/21186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieabe714328aa2cc605cb62b85ae8aa4bd537dbe9 Gerrit-Change-Number: 21186 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 01 Apr 2024 03:37:21 +0000 Gerrit-HasComments: Yes
