Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21045 )
Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/21045/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21045/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1067 PS5, Line 1067: metrics_.getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).inc(skippedEvent); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21045/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1071 PS5, Line 1071: metrics_.getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).inc(skippedEvent); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21045/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2349 PS5, Line 2349: metrics_.getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).getCount()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21045/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2658 PS5, Line 2658: metrics_.getCounter(MetastoreEventsProcessor.EVENTS_SKIPPED_METRIC).inc(eventsToProcess.size() + partitionEventsToForceReload.size()); line too long (144 > 90) http://gerrit.cloudera.org:8080/#/c/21045/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2676 PS5, Line 2676: FileMetadataLoadOpts.FORCE_LOAD, getEventType().toString() + " event", true); line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a Gerrit-Change-Number: 21045 Gerrit-PatchSet: 5 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 02 Apr 2024 03:53:21 +0000 Gerrit-HasComments: Yes
