Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21219 )
Change subject: IMPALA-12899: Temporary workaround for BINARY in complex types ...................................................................... Patch Set 4: (3 comments) Thanks for the patch! I general this looks good. http://gerrit.cloudera.org:8080/#/c/21219/4/be/src/exec/iceberg-metadata/iceberg-row-reader.cc File be/src/exec/iceberg-metadata/iceberg-row-reader.cc: http://gerrit.cloudera.org:8080/#/c/21219/4/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@328 PS4, Line 328: return heap_byte_buffer_cl_; I understand this will be needed for the permanent solution and not the NULLing, but I feel that a patch should contain only what it is required for that patch. Would it be possible to remove what is not needed now? http://gerrit.cloudera.org:8080/#/c/21219/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/21219/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@813 PS4, Line 813: file_path":"hdfs://localhost:20500/test-warehouse/iceberg_test/hadoop_catalog/ice/ic not sure about this but for dockerised builds don't the file paths start with '/test-warehouse/' without 'hdfs://localhost:20500'? I think it's safer to have a regexp here http://gerrit.cloudera.org:8080/#/c/21219/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@819 PS4, Line 819: ==== One possible extra test case is to set the EXPAND_COMPLEX_TYPES true and do a select * on a metadata table. -- To view, visit http://gerrit.cloudera.org:8080/21219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d834126c7d702a25e957bb6071ecbf0fda2c203 Gerrit-Change-Number: 21219 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 02 Apr 2024 08:56:31 +0000 Gerrit-HasComments: Yes
