Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 )
Change subject: IMPALA-6131: Track time of last statistics update in metadata ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/10116/7/tests/metadata/test_last_ddl_time_update.py File tests/metadata/test_last_ddl_time_update.py: http://gerrit.cloudera.org:8080/#/c/10116/7/tests/metadata/test_last_ddl_time_update.py@52 PS7, Line 52: > Mention the supported substitutions in the methods below (and add comments Done http://gerrit.cloudera.org:8080/#/c/10116/7/tests/metadata/test_last_ddl_time_update.py@56 PS7, Line 56: substituted > Is there a reason we don't test changes to both? Do they never change at th There is no statement that should change both. http://gerrit.cloudera.org:8080/#/c/10116/7/tests/metadata/test_last_ddl_time_update.py@76 PS7, Line 76: ns the given queries > Do you need to specify the class to access TestHelper? Yes, adding the outer classes is necessary in this case, h = TestHelper(...) would lead to "NameError: global name 'TestHelper' is not defined". It is also valid to use self.TestHelper(...) but I think that it is weird, so I prefer adding the class name. http://gerrit.cloudera.org:8080/#/c/10116/7/tests/metadata/test_last_ddl_time_update.py@179 PS7, Line 179: # dynamic partition insert > Can you move this method into the Helper class now? Done - this change resulted in a bit less code but more indentation, so I am not sure that it is better this way. -- To view, visit http://gerrit.cloudera.org:8080/10116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59a671ac29d352bd92ce40d5cb6662bb23f146b5 Gerrit-Change-Number: 10116 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 04 May 2018 17:50:40 +0000 Gerrit-HasComments: Yes
