Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/10289 )
Change subject: IMPALA-6948: Delete catalog update topic entries upon catalog restart ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10289/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10289/1//COMMIT_MSG@22 PS1, Line 22: full topic update > I don't think so because the "full topic update" after a catalogd restart o Correct. http://gerrit.cloudera.org:8080/#/c/10289/1/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: http://gerrit.cloudera.org:8080/#/c/10289/1/common/thrift/StatestoreService.thrift@128 PS1, Line 128: 7: optional bool clear_topic_entries > Isn't this what 'is_delta=false' should do? Yes, we could use is_delta for that purpose. However, it is kind of risky since this is a required field that is set by default, so an error setting this to the correct value by any of the subscribers could trigger a full topic deletion. -- To view, visit http://gerrit.cloudera.org:8080/10289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74a8ade8e498ac35cb56d3775d2c67a86988d9b6 Gerrit-Change-Number: 10289 Gerrit-PatchSet: 1 Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 04 May 2018 18:54:59 +0000 Gerrit-HasComments: Yes
