Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20131 )
Change subject: IMPALA-12152: Add query option to wait for events sync up ...................................................................... Patch Set 14: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20131/14/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20131/14/be/src/service/client-request-state.cc@601 PS14, Line 601: coord_->AddErrorLog(early_error_msg_); Can/should we clear early_error_msg_ here? Could at least free up the memory. http://gerrit.cloudera.org:8080/#/c/20131/14/tests/metadata/test_event_processing_base.py File tests/metadata/test_event_processing_base.py: http://gerrit.cloudera.org:8080/#/c/20131/14/tests/metadata/test_event_processing_base.py@30 PS14, Line 30: class TestEventProcessingBase(ImpalaTestSuite): nit: either this doesn't need to inherit from ImpalaTestSuite, or you could have TestEventProcessing inherit from in. Do the SkipIf clauses do anything? -- To view, visit http://gerrit.cloudera.org:8080/20131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36ac941bb2c2217b09fcfa2eb567b011b38efa2a Gerrit-Change-Number: 20131 Gerrit-PatchSet: 14 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 03 Apr 2024 23:57:27 +0000 Gerrit-HasComments: Yes
