Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/21236 )
Change subject: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21236/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21236/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-12612: SELECT * queries expand complex type columns from Iceberg metadata tables > The title could include "select *", otherwise it's not clear what this refe Done http://gerrit.cloudera.org:8080/#/c/21236/1//COMMIT_MSG@9 PS1, Line 9: > Nit: should come after "behave". Done http://gerrit.cloudera.org:8080/#/c/21236/1//COMMIT_MSG@14 PS1, Line 14: Note, the behavior of handling nested columns from regular tables > We could mention that although this is technically a breaking change, metad I don't think this is a breaking change because we don't have a release ATM that contains metadata querying. I checked that the parser and planner parts went into 4.3 but the executor part is waiting for 4.4 so we are safe with this change. http://gerrit.cloudera.org:8080/#/c/21236/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/21236/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@25 PS1, Line 25: $NAMENODE/test-warehou > Is it intentional that these are changed from "$NAMENODE" to "hdfs://localh it isn't, thanks for noticing. dockerised GVO also broke because of this http://gerrit.cloudera.org:8080/#/c/21236/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@1110 PS1, Line 1110: select readable_metrics.i.* from functional_parquet.iceberg_query_metadata.`files`; > This example can be confusing at first because the 'readable_metrics' struc I changed this to expand readable_metrics.i -- To view, visit http://gerrit.cloudera.org:8080/21236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia298705ba54411cc439e99d5cb27184093541f02 Gerrit-Change-Number: 21236 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 04 Apr 2024 05:03:06 +0000 Gerrit-HasComments: Yes
