Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21218 )
Change subject: IMPALA-12925: Fix decimal data type for external JDBC table ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21218/9/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/21218/9/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@194 PS9, Line 194: new TStatus(TErrorCode.INTERNAL_ERROR, Lists.newArrayList(e.getMessage()))); > Why is this an internal error? Isn't it misconfiguration between table defi The errors are caused by misconfiguration between JDBC table definition and remote tables in RDBMS, like upsupported column data type, invalid decimal precision and scale, etc. The error messages will be returned to client. We can define an error code for JDBC configuration. http://gerrit.cloudera.org:8080/#/c/21218/9/testdata/bin/clean-mysql-env.sh File testdata/bin/clean-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/21218/9/testdata/bin/clean-mysql-env.sh@38 PS9, Line 38: rm -f /tmp/mysql_jdbc_decimal_tbl.* > Why are these created here instead of testdata/data? These files are created by testdata/bin/setup-mysql-env.sh when running unit-tests for MySQL. These are temp files used for creating table and loading data for MySQL when setting up MySQL server. We clean up these files after the MySQL server has been setup. -- To view, visit http://gerrit.cloudera.org:8080/21218 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c9d2e0667c42c0e52436b158e3dfe3ec14b9e3b Gerrit-Change-Number: 21218 Gerrit-PatchSet: 9 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 04 Apr 2024 21:09:57 +0000 Gerrit-HasComments: Yes
