Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20263 )
Change subject: WIP IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20263/7/package/CMakeLists.txt File package/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20263/7/package/CMakeLists.txt@39 PS7, Line 39: FILE(GLOB gcc_lib ${IMPALA_GCC_HOME}/lib64/libgcc_s.so.1*) : install(FILES ${gcc_lib} DESTINATION ${IMPALA_INSTALLDIR}/lib/native) : : FILE(GLOB cpp_lib ${IMPALA_GCC_HOME}/lib64/libstdc++.so.6*) : install(FILES ${cpp_lib} DESTINATION ${IMPALA_INSTALLDIR}/lib/native) : : set(KUDU_HOME $ENV{IMPALA_TOOLCHAIN_PACKAGES_HOME}/kudu-$ENV{IMPALA_KUDU_VERSION}/release) : # The parent folder is lib64 on centos/redhat, while on ubuntu it's lib. : FILE(GLOB kudu_lib ${KUDU_HOME}/lib*/libkudu_client.so*) : install(FILES ${kudu_lib} DESTINATION ${IMPALA_INSTALLDIR}/lib/native) : : FILE(GLOB hadoop_lib $ENV{HADOOP_LIB_DIR}/native/libhadoop.so*) : install(FILES ${hadoop_lib} DESTINATION ${IMPALA_INSTALLDIR}/lib/native) Can we add a check that if any of these files are not found, exit the build? I encountered such issue when backporting the packaging support to older branches. -- To view, visit http://gerrit.cloudera.org:8080/20263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 20263 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2024 05:28:00 +0000 Gerrit-HasComments: Yes
