Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21171 )
Change subject: IMPALA-12905: Disk-based tuple caching ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21171/9/be/src/exec/tuple-file-writer.h File be/src/exec/tuple-file-writer.h: http://gerrit.cloudera.org:8080/#/c/21171/9/be/src/exec/tuple-file-writer.h@46 PS9, Line 46: wtihout nit. without http://gerrit.cloudera.org:8080/#/c/21171/9/be/src/runtime/tuple-cache-mgr.h File be/src/runtime/tuple-cache-mgr.h: http://gerrit.cloudera.org:8080/#/c/21171/9/be/src/runtime/tuple-cache-mgr.h@110 PS9, Line 110: increament nit. increment -- To view, visit http://gerrit.cloudera.org:8080/21171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a65c4c0559cad3559d5f714a074dd06e9cc9bf Gerrit-Change-Number: 21171 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 22:28:07 +0000 Gerrit-HasComments: Yes
